Dates aren't constrained

[HeatherHMorgan]

Earlier when I tried to enter onset of symptoms / test date that was later than the current date, I was not able to do so. However, when I was testing it out just now, I was able to enter future dates.

[dllh]

Hmm, I'll check on this again. I tested one case like this and discovered an issue with the grades field as a side effect of form validation on dates preventing a submit, but in that case, the constraint did work as expected. I may've introduced a bug in my "symptomatic" checkbox fix.

[dllh]

I may need some more specifics here. I've tried reproducing now and was not able to enter future dates:

If you're still able to reproduce, can you share with me a screen shot of what you're submitting (or provide the relevant details if that's easier)? I was working on semi-related things last night, and I wonder if you happened to test at a time during which validation was broken. You may also have found a use case that I haven't hit upon yet.

[HeatherHMorgan]

Last night on 9/6, I was able to enter Carter High 9/7 symptom onset and Farragut High 9/7 positive COVID test.

On Tue, Sep 7, 2021 at 9:55 PM Daryl L. L. Houston @.***> wrote:

I may need some more specifics here. I've tried reproducing now and was not able to enter future dates:

[image: Screen Shot 2021-09-07 at 9 53 17 PM] https://user-images.githubusercontent.com/2738252/132433503-a89c8359-6d41-44b2-ab5f-1d68ff389de9.png

If you're still able to reproduce, can you share with me a screen shot of what you're submitting (or provide the relevant details if that's easier)? I was working on semi-related things last night, and I wonder if you happened to test at a time during which validation was broken. You may also have found a use case that I haven't hit upon yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dllh/kcs-tracing.org/issues/25#issuecomment-914810695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVPXSS3WNU23PSWEGWFJFMTUA27CNANCNFSM5DRPNCZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Heather Morgan | 1304 Branton Boulevard, Knoxville, TN 37922 | 865.247.2114

[HeatherHMorgan]

I was also able to enter this just now:

[image: image.png]

On Tue, Sep 7, 2021 at 10:04 PM Heather Hubbard Morgan < @.***> wrote:

Last night on 9/6, I was able to enter Carter High 9/7 symptom onset and Farragut High 9/7 positive COVID test.

On Tue, Sep 7, 2021 at 9:55 PM Daryl L. L. Houston < @.***> wrote:

I may need some more specifics here. I've tried reproducing now and was not able to enter future dates:

[image: Screen Shot 2021-09-07 at 9 53 17 PM] https://user-images.githubusercontent.com/2738252/132433503-a89c8359-6d41-44b2-ab5f-1d68ff389de9.png

If you're still able to reproduce, can you share with me a screen shot of what you're submitting (or provide the relevant details if that's easier)? I was working on semi-related things last night, and I wonder if you happened to test at a time during which validation was broken. You may also have found a use case that I haven't hit upon yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dllh/kcs-tracing.org/issues/25#issuecomment-914810695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVPXSS3WNU23PSWEGWFJFMTUA27CNANCNFSM5DRPNCZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Heather Morgan | 1304 Branton Boulevard, Knoxville, TN 37922 | 865.247.2114

-- Heather Morgan | 1304 Branton Boulevard, Knoxville, TN 37922 | 865.247.2114

[HeatherHMorgan]

Also, this:

[image: image.png] First potential issue - date is in the future. Second, I didn't check the symptomatic box and it entered a value that is the same as the positive test result date. Is that the desired behavior?

Thanks! Heather

On Tue, Sep 7, 2021 at 10:14 PM Heather Hubbard Morgan < @.***> wrote:

I was also able to enter this just now:

[image: image.png]

On Tue, Sep 7, 2021 at 10:04 PM Heather Hubbard Morgan < @.***> wrote:

Last night on 9/6, I was able to enter Carter High 9/7 symptom onset and Farragut High 9/7 positive COVID test.

On Tue, Sep 7, 2021 at 9:55 PM Daryl L. L. Houston < @.***> wrote:

I may need some more specifics here. I've tried reproducing now and was not able to enter future dates:

[image: Screen Shot 2021-09-07 at 9 53 17 PM] https://user-images.githubusercontent.com/2738252/132433503-a89c8359-6d41-44b2-ab5f-1d68ff389de9.png

If you're still able to reproduce, can you share with me a screen shot of what you're submitting (or provide the relevant details if that's easier)? I was working on semi-related things last night, and I wonder if you happened to test at a time during which validation was broken. You may also have found a use case that I haven't hit upon yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dllh/kcs-tracing.org/issues/25#issuecomment-914810695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVPXSS3WNU23PSWEGWFJFMTUA27CNANCNFSM5DRPNCZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Heather Morgan | 1304 Branton Boulevard, Knoxville, TN 37922 | 865.247.2114

-- Heather Morgan | 1304 Branton Boulevard, Knoxville, TN 37922 | 865.247.2114

-- Heather Morgan | 1304 Branton Boulevard, Knoxville, TN 37922 | 865.247.2114

[dllh]

First potential issue - date is in the future.

Alas, the screen shots didn't come through via an email reply to the thread. Can you add one through the GitHub interface?

I have a theory, which is that our server is at present running on UTC, so if we're testing at night, four hours behind UTC, and we enter tomorrow, it'll already be tomorrow after our 8pm. I wonder if that's what's happening. I think my tests have tended to be a few days in the future, so they failed.

Second, I didn't check the symptomatic box and it entered a value that is the same as the positive test result date. Is that the desired behavior?

I don't know that it's desired, but for the moment, it was intentional. To set the new case date, I'm picking the earliest of the two dates and setting a flag in the database to mark a record as one with a "symptomatic" date. I was just saving the test date as symptomatic date too since I had the flag to differentiate. I could maybe set it to 0000-00-00' orNULL` instead. For now, I've just updated the view to display the symptomatic date only if the checkbox was ticked. I believe this'll resolve that issue at least.

[HeatherHMorgan]

Hope the above image comes through. I was wondering if it was due to time zone...I bet that is it!

10-4 on the behavior of the flag / date that is entered for symptomatic. I think it's totally fine as the "information" that we need is all there with the flag AND it doesn't mess up our earlier of calculation.

Thanks! Heather