dllhlx / inxi

Automatically exported from code.google.com/p/inxi
0 stars 0 forks source link

Fixed some missed quotes inxi_2.2.14 #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Well done script! 

It worked flawlessly from the directory I unpacked it in yet when I made an 
alias to it I noticed some errors regarding the space and found some 
missing quotes:  

I made the following changes and the errors went away:
Line 995, quoted missed quote on $0 => SCRIPT_PATH=$( dirname "$0" )

Line 967-982, quoted missed quotes on $SCRIPT_PATH/$SCRIPT_NAME in call to 
gawk. 
To make it more clear I removed the quotes on the process substitution 
since the embedded quoted throw people for a loop at first glance => 
            version_data=$(gawk -F ': ' '
            /####[[:space:]]+Date:/ {
                print $NF
            }' "$SCRIPT_PATH/$SCRIPT_NAME")
            ;;
        main)
            version_data=$(gawk '
            /####[[:space:]]+Version:/ {
                print $3
            }' "$SCRIPT_PATH/$SCRIPT_NAME")
            ;;
        patch)
            version_data=$(gawk '
            /####[[:space:]]+Patch Number:/ {
                print $4
            }' "$SCRIPT_PATH/$SCRIPT_NAME") 

Original issue reported on code.google.com by adam.dan...@gmail.com on 24 Jan 2015 at 5:12

Attachments:

GoogleCodeExporter commented 9 years ago
Thank you for the complete bug / issue report and patch. This is updated in 
inxi 2.2.18

Original comment by inxi-...@techpatterns.com on 24 Jan 2015 at 6:54