dllmusic / moDllz

VCV Rack plugins
Other
15 stars 4 forks source link

MIDI Poly+MPE should not reattack the last note depressed #22

Closed caoliver closed 2 years ago

caoliver commented 3 years ago

I often use MIDI Poly+MPE in mono to get correct functionality for the sustain pedal. (Think holding a note while playing two other keyboards.) One issue I see when in retrigger mode is that the last note gets reattacked when an older note is released. Steps to recreate: 1) Set up a patch with MIDI Poly+MPE as your MIDI input connection. 2) Set the voice channels to 1. 3) Press and hold a key. 4) Press and hold a different key. 5) Release the first key. The note playing gets reattacked. This should only happen if the note is different. The trouble is that this gives bogus duplicated notes when playing legato with retrigger active.

dllmusic commented 3 years ago

Thanks for reporting. I will check into this

On Sat, Feb 6, 2021 at 9:21 AM caoliver notifications@github.com wrote:

I often use MIDI Poly+MPE in mono to get correct functionality for the sustain pedal. (Think holding a note while playing two other keyboards.) One issue I see when in retrigger mode is that the last note gets reattacked when an older note is released. Steps to recreate: 1) Set up a patch with MIDI Poly+MPE as your MIDI input connection. 2) Set the voice channels to 1. 3) Press and hold a key. 4) Press and hold a different key. 5) Release the first key. The note playing gets reattacked. This should only happen if the note is different. The trouble is that this gives bogus duplicated notes when playing legato with retrigger active.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dllmusic/moDllz/issues/22, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIEJ36FN44COZ2OIGSLYCKTS5VGADANCNFSM4XGKNWNA .

dllmusic commented 2 years ago

I finally got back to this project and I'm about to release v2 with this fixed.