search

dllmusic / moDllz

VCV Rack plugins
Other
15 stars 4 forks source link

Haken MPE+ mode broken but I figured out the fix #27

Open SteveElbows opened 1 year ago

SteveElbows commented 1 year ago

Hi,

Thanks for these plugins. The Haken MPE+ mode is of increased interest because the Expressive E Osmose keyboard which recently became available can output MPE+ on its usb midi port 2.

However this mode was broken for me, only got low and erratic voltages out from MPE Z and MPE Y in your plugin when using this mode.

I took a look at the sourcecode and figured out the fix. The problem was that your dualbytetoVolts function was written to receive a uint8_t instead of a uint16_t. So to fix things I only had to change lines 567 of MIDIpolyMPE.cpp to be:

float dualbytetoVolts(uint16_t mididata){

Thanks!

dllmusic commented 1 year ago

Thank you Steve!! I'm glad you found this!... I actually never tested it with the continuum. I'll post an update with this fix soon. (I have a few more things fixed on other modules as well) Pablo

On Sat, Jan 14, 2023 at 1:32 PM SteveElbows @.***> wrote:

Hi,

Thanks for these plugins. The Haken MPE+ mode is of increased interest because the Expressive E Osmose keyboard which recently became available can output MPE+ on its usb midi port 2.

However this mode was broken for me, only got low and erratic voltages out from MPE Z and MPE Y in your plugin when using this mode.

I took a look at the sourcecode and figured out the fix. The problem was that your dualbytetoVolts function was written to receive a uint8_t instead of a uint16_t. So to fix things I only had to change lines 567 to be:

float dualbytetoVolts(uint16_t mididata){

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/dllmusic/moDllz/issues/27, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIEJ36FP33ACISFSUVHR6WDWSLWNHANCNFSM6AAAAAAT3M6OYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>