search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.56k stars 382 forks source link

Update node-sass to 4.12.0 #720

Closed simonua closed 5 years ago

simonua commented 5 years ago

Fixes #719

The same three tests fail pre- and post-change, so this PR does not appear to have any impact.

chuanxd commented 5 years ago

LGTM

simonua commented 5 years ago

@dlmanning, could this be merged, please? Thank you!

pmrotule commented 5 years ago

After running system updates on my MacBook Pro over the weekend (macOS Mojave version 10.14.3), I was having a Node Sass error coming from gulp-sass when I tried to start my web server: Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (67). A good old npm rebuild node-sass wasn't helping this time. I also tried to delete _nodemodules folder and re-install everything: didn't help either.

At the end, I realized that gulp-sass was not using the latest version of node-sass and using this fork, I was finally able to start my server as usual.

Thanks @simonua, can't wait to see this PR merged.

xzyfer commented 5 years ago

npm update node-sass is the npm way of updating a transient dependency.

On Mon., 18 Feb. 2019, 7:28 pm Pierre-Michel Brown <notifications@github.com wrote:

After running system updates on my MacBook Pro over the weekend (macOS Mojave version 10.14.3), I was having a Node Sass error coming from gulp-sass when I tried to start my web server: Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (67). A good old npm rebuild node-sass wasn't helping this time. I also tried to delete node_modules folder and re-install everything: didn't help either.

At the end, I realized that gulp-sass was not using the latest version of node-sass and using this fork, I was finally able to start my server as usual.

Thanks @simonua https://github.com/simonua, can't wait to see this PR merged.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/720#issuecomment-464634051, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjZWKldlEVHtge3t7rrMxLgmGHIaBrpks5vOmRAgaJpZM4YticH .

simonua commented 5 years ago

@pmrotule, you're welcome. Your situation applied to me similarly on the Windows side. =P

jrgcubano commented 5 years ago

hey @xzyfer really waiting for rgba, rgb and custom vars

gulp-sass -> node-sass (even with 4.11 we need to wait until node-sass update to sass 3.56 with rgba vars) -> lib-sass

issue in node-sass

danielpost commented 5 years ago

Would be great if this could get merged so we can get rid of the CSS import warning.

simonua commented 5 years ago

@dlmanning, just a ping to float this back to the top of your inbox, good sir. It would be great if this could be merged and released, please.

Thank you!

xzyfer commented 5 years ago

npm update node-sass

On Tue., 26 Mar. 2019, 3:56 am Simon Kurtz, notifications@github.com wrote:

@dlmanning https://github.com/dlmanning, just a ping to float this back to the top of your inbox, good sir. It would be great if this could be merged and released, please.

Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/720#issuecomment-476287504, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjZWN5QlOBFo3wwrZHHTzec0-qpD-5kks5vaP_CgaJpZM4YticH .

simonua commented 5 years ago

I updated the PR with the latest version of node-sass released a few days ago that now supports NodeJS 12. @dlmanning, would be really, really great if this could be merged and released. Pretty please.

hachibu commented 5 years ago

My project really needs this as well. Thank you so much!

TheDancingCode commented 5 years ago

As @xzyfer already said twice, this PR isn't necessary. The solution is to simply npm update node-sass in your project.

acdha commented 5 years ago

@TheDancingCode: it’s better to have safe defaults than hope people find that default buried in an issue tracker after hitting a problem because they mistakenly assumed that npm install gulp-sass would do the right thing.

simonua commented 5 years ago

True, not necessary, and the suggestion helps, but I agree with good defaults and good package maintenance. Such is a team sport.

uunbound commented 5 years ago

If you are using yarn to install your npm packages, you can use this solution to force installing node-sass v4.12.0.

xzyfer commented 5 years ago

This is not needed because of how SemVer works. You can always update the transient node-sass with npm update node-sass if you wish.

https://nodesource.com/blog/semver-tilde-and-caret