search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.56k stars 381 forks source link

Update node-sass 5.0.0 #781

Closed tanrax closed 3 years ago

rekmarks commented 3 years ago

It would be positively astounding if this were merged 🙏

rekmarks commented 3 years ago

It'll probably require a major version bump of gulp-sass due to changes to permitted Node version, but it doesn't look like it'll require any code changes: https://github.com/sass/node-sass/releases/tag/v5.0.0

tanrax commented 3 years ago

Only with this small change it works for me

sujeetkrjaiswal commented 3 years ago

Why should gulp-sass needs a dependency on node-sass, given users can choose between node-sass and sass (dart-sass) as a compiler? An issue also has been opened for this: https://github.com/dlmanning/gulp-sass/issues/782

C-Lodder commented 3 years ago

Just make it a peerDependency so people have to manually install and manage the node-sass version. Depending on a package that needs to ship new binaries for every Node.js version is a PITA

rekmarks commented 3 years ago

Signal boost: The problem hasn't gone away; I'd still love for this to happen.

xzyfer commented 3 years ago

Thanks all, close this to focus efforts on #802 which is more rounded at this point in time.