search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.56k stars 381 forks source link

Replace node-sass with sass #786

Closed MrFlashAccount closed 3 years ago

MrFlashAccount commented 3 years ago

Node-sass is deprecated, I've moved this project to sass.

ruxxzebre commented 3 years ago

I had a lot of troubles with that, because of incompatibility of node-sass 4 with osx manjaro (!!!!), so it would be great for the maintainer to fix this, or at least update node-sass to 5.

ruxxzebre commented 3 years ago

@MrFlashAccount friendly suggestion, config your global gitignore to ignore the .idea, .vscode, etc, so not to mess the project's gitignore file, because it's not the best practice, kinda clogging project a bit. Also, it'll just make your life easier, so you don't need to mention temp files and other cache folders in every project. Peace :3

MrFlashAccount commented 3 years ago

@ruxxzebre thank you for your advice :)

jerrylow commented 3 years ago

BTW tested this PR and it's working great.

manelephant commented 3 years ago

Would be great if this could be merged

tachojelev commented 3 years ago

Hi guys, when can we expect this to be merged and released?

darkoandreev commented 3 years ago

Hi guys, our project highly depends on this PR. It would be really nice if @Prometee and @jerrylow could review it. Thanks in advance!

yairEO commented 3 years ago

I also need this urgently... may the author perhaps do these quick 2-lines changes himself directly on the Master branch and rid us of the huge waste of time - arguing about all those extra files added to this PR? 🧐🥱

Prometee commented 3 years ago

@yairEO I'm not the library author just a random dev having the same problem like you. Reviews on this repository are open to all GitHub accounts, only the maintainers are able to accept or refuse this PR.

yairEO commented 3 years ago

Yes, I know, I was writing this for the maintainer to read

richard-giraud commented 3 years ago

I've submitted a PR that is the same, except it doesn't have the idea folder or the yarn.lock files.

xzyfer commented 3 years ago

Thanks all, close this to focus efforts on #802 which is more rounded at this point in time.