search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.57k stars 381 forks source link

Travis CI: Tests fail on Node.js >= v12 #789

Closed cclauss closed 3 years ago

cclauss commented 3 years ago

https://travis-ci.org/github/dlmanning/gulp-sass/pull_requests

https://nodejs.org/api/fs.html

xzyfer commented 3 years ago

Thanks you but we should not fail on these node versions so instead we need to fix the root cause of the failures.

cclauss commented 3 years ago

We need to fix the root cause of the failures.

Once that is done, the last 5 lines could be deleted and we would have up-to-date tests.

xzyfer commented 3 years ago

Apologies I thought there were two separate PRs. Lets remove the allowed failures and I'll look into the build failures.

xzyfer commented 3 years ago

I can't reopen the PR because the branch has been deleted

cclauss commented 3 years ago

Recreated in #790