search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.56k stars 381 forks source link

Pass along sass's `stats` object #808

Open WraithKenny opened 3 years ago

WraithKenny commented 3 years ago

The stats object that's returned from the sass compiler contains some interesting info, particularly includedFiles which can be used to develop smarter watchers. Related to #279, fixed #428

WraithKenny commented 3 years ago

I named the property sassStats instead of stats to avoid confusion or potential collision.

niksy commented 3 years ago

What can we do to get this merged? This would definitely help in creating smarter watchers.

XhmikosR commented 2 years ago

I think if you extended the tests to cover this, it should help to land this. Also, this should probably be documented?

/CC @xzyfer

niksy commented 2 years ago

@WraithKenny are you up for this?

WraithKenny commented 2 years ago

Honestly, I've never quite figured out extending tests; I have no idea what I'm doing with regards to that. If anyone wants to adopt this issue/patch, you are more than welcome!

XhmikosR commented 2 years ago

You'd need to rebase the branch first and then add 2 tests for the new property in https://github.com/dlmanning/gulp-sass/blob/master/test/main.js

niksy commented 2 years ago

@XhmikosR @WraithKenny I’ve created new PR with tests

XhmikosR commented 2 years ago

I don't have push rights, so @xzyfer will need to take care of it :)