search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.57k stars 381 forks source link

Properly disable package-lock.json #815

Closed XhmikosR closed 3 years ago

xzyfer commented 3 years ago

Thanks but having this file gives up reproducible builds.

XhmikosR commented 3 years ago

Err what are you talking about? You don't have a lock file commited...

On Mon, Oct 4, 2021, 11:47 Michael Mifsud @.***> wrote:

Closed #815 https://github.com/dlmanning/gulp-sass/pull/815.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/815#event-5402338075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVLNNMKYFXRK4H7PPM3MTUFFZ4FANCNFSM5FISNS3Q .

XhmikosR commented 3 years ago

This PR does not change the existent behavior. It simply properly disables the lock file.

If you want a lock file, that's OK, but it's not the case on master.

So, if you are going to add a lock file, I should also update my CI PR to use npm ci. Otherwise this patch is good to go.

On Mon, Oct 4, 2021, 11:48 XhmikosR @.***> wrote:

Err what are you talking about? You don't have a lock file commited...

On Mon, Oct 4, 2021, 11:47 Michael Mifsud @.***> wrote:

Closed #815 https://github.com/dlmanning/gulp-sass/pull/815.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/815#event-5402338075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVLNNMKYFXRK4H7PPM3MTUFFZ4FANCNFSM5FISNS3Q .