search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.57k stars 381 forks source link

Minor tweaks and cleanup #822

Closed XhmikosR closed 3 years ago

XhmikosR commented 3 years ago

Non-whitespace diff is cleaner: https://github.com/dlmanning/gulp-sass/pull/822/files?w=1

XhmikosR commented 3 years ago

I'm going to move the other changes to separate PRs so that's easier to review :)

xzyfer commented 3 years ago

Migrating to GitHub actions was a great value add, but I don't think there's value in materially changing the plugin itself. It's been largely unchanged for a couple years now and is prefer to keep it that way from a maintenance perspective.

On Thu, 7 Oct 2021, 3:01 pm XhmikosR, @.***> wrote:

I'm going to move the other changes to separate PRs so that's easier to review :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/822#issuecomment-937424105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSWBUN27HS2T4G64DOZTUFULQ3ANCNFSM5FOFWFEA .

XhmikosR commented 3 years ago

I see your point, totally, but all I'm trying to do is to only make the code simpler for the future.

And since I've already done most of the changes, it'd be a pity to not land them :)

XhmikosR commented 3 years ago

Are you OK with landing this and this too? I just move the functions outside for better organization and renamed a few variables.

xzyfer commented 3 years ago

Sure. I'll take a closer look when they're in a PR before merging.

XhmikosR commented 3 years ago

They depend on this PR, should I push them here as separate patches and you squash when merging?

xzyfer commented 3 years ago

Yeah just land the commits here. I've already read this PR so I can audit those individual commits as part of this PR.

On Fri, 8 Oct 2021, 11:11 pm XhmikosR, @.***> wrote:

They depend on this PR, should I push them here as separate patches and you squash when merging?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/822#issuecomment-938592329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSWGXDNVHY4KFYYZQO5TUF3NXDANCNFSM5FOFWFEA .

xzyfer commented 3 years ago

Thanks!