Closed XhmikosR closed 2 years ago
I'm going to move the other changes to separate PRs so that's easier to review :)
Migrating to GitHub actions was a great value add, but I don't think there's value in materially changing the plugin itself. It's been largely unchanged for a couple years now and is prefer to keep it that way from a maintenance perspective.
On Thu, 7 Oct 2021, 3:01 pm XhmikosR, @.***> wrote:
I'm going to move the other changes to separate PRs so that's easier to review :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/822#issuecomment-937424105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSWBUN27HS2T4G64DOZTUFULQ3ANCNFSM5FOFWFEA .
I see your point, totally, but all I'm trying to do is to only make the code simpler for the future.
And since I've already done most of the changes, it'd be a pity to not land them :)
Sure. I'll take a closer look when they're in a PR before merging.
They depend on this PR, should I push them here as separate patches and you squash when merging?
Yeah just land the commits here. I've already read this PR so I can audit those individual commits as part of this PR.
On Fri, 8 Oct 2021, 11:11 pm XhmikosR, @.***> wrote:
They depend on this PR, should I push them here as separate patches and you squash when merging?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/822#issuecomment-938592329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSWGXDNVHY4KFYYZQO5TUF3NXDANCNFSM5FOFWFEA .
Thanks!
Non-whitespace diff is cleaner: https://github.com/dlmanning/gulp-sass/pull/822/files?w=1