search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.56k stars 381 forks source link

Remove strip-ansi dependency #825

Closed XhmikosR closed 2 years ago

XhmikosR commented 2 years ago

This one needs close review, but I think that strip-ansi was just stripping chalk's ANSI escapes. Now, the question is if the sass compilers add ANSI escapes.

There's a little duplication, but I couldn't find a way to simplify this. Any ideas welcome!

XhmikosR commented 2 years ago

BTW are we sure that the compilers won't output any ANSI escapes?

xzyfer commented 2 years ago

BTW are we sure that the compilers won't output any ANSI escapes? No. Since I can't be sure how safe this is I'm opting not to proceed since this change is purely cosmetic.

xzyfer commented 2 years ago

Thanks for your work

XhmikosR commented 2 years ago

TBH, the tests do pass, though, which means the compilers don't actually output ANSI escapes.

xzyfer commented 2 years ago

The test only run very trivial sass files thought. I'm fairly certain the stack traces returned by some sass compilers may use ANSI escapes. Also we can't control is compiler behaviour changes in the future so I think we have the more robust approach.