search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.57k stars 381 forks source link

Add c8 for coverage #827

Closed XhmikosR closed 3 years ago

XhmikosR commented 3 years ago

It's the most lightweight solution I'm aware of.

Happy to adapt the npm scripts to your liking.

xzyfer commented 3 years ago

I typically default to nyc but I dunno how well that plays along with mocha.

XhmikosR commented 3 years ago

Both work well, but c8 is a lot lighter :)

https://packagephobia.com/result?p=c8%2Cnyc

PS. I didn't connect this to any coverage service since it's just one file, but it should be pretty easy to do it later with actions.

xzyfer commented 3 years ago

Honestly coverage is not a goal of this project and I plan to freeze this codebase when your clean up PR lands. As I mentioned earlier I don't want to add churn that doesn't add value.

This package is in maintenance mode. We will not be adding new features so changing testing, coverage, and code formatting isn't something I want to encourage.

Thanks for all your work but after that clean up PR lands I don't plan to merge any PRs that aren't fixing bugs or security notices .

XhmikosR commented 3 years ago

NP, although this doesn't hurt and it makes it easy to spot what's covered and what's not in tests.