search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.56k stars 381 forks source link

Add sass tests too #842

Closed XhmikosR closed 2 years ago

XhmikosR commented 2 years ago

@xzyfer I think it's worth having this. That being said, I noticed a few differences while working on this patch. This one makes me wonder:

https://github.com/dlmanning/gulp-sass/pull/842/files#diff-5a684c173d69bcc8d9e0e4b50ac83d8eaf640dbd8e141c14d9e1a953c87afbd3R482

XhmikosR commented 2 years ago

Oh, and if you have another idea how to implement this; I went with the environment variable solution.

XhmikosR commented 2 years ago

@xzyfer how about releasing a new minor version? We've landed plenty of changes and personally I don't have any further ones. :)

EDIT: apart from https://github.com/dlmanning/gulp-sass/pull/286#issuecomment-1002468420 but I'm not sure it's still an issue anyway.

xzyfer commented 2 years ago

v5.1.0 has been released