search

dloa / alexandria-browser

Original OIP browsing UI. Outdated. See https://github.com/dloa/browser-react
14 stars 9 forks source link

Paywall Use jQuery QRCode #42

Closed cchrysostom closed 8 years ago

cchrysostom commented 8 years ago

media.js setQR makes an external call to api.qrserver.com to generate a QR Code image in the paywall. Adjust this method to use the internal javascript to create image to reduce cross site scripting. Chris can make this change.

OstlerDev commented 8 years ago

This is what I use currently and I highly suggest it. It is used in several other DLOA apps https://davidshimjs.github.io/qrcodejs/

cchrysostom commented 8 years ago

Thanks. I did find qrcodejs. But, although jQuery QRCode is old, now, it is used in several places around Browser. I hesitate introducing another library unless @copernicus-mogley wants to swap it out. I do agree we should minimize calls to external web API's, though.

cchrysostom commented 8 years ago

This pull request addresses the issue.