search

dloa / browser-react

React version of the Alexandria Browser
2 stars 2 forks source link

PDF embedding #57

Open RoguePlanetArt opened 7 years ago

RoguePlanetArt commented 7 years ago

Hey all, uploaded my short story (The Death of Paul Shephard) to DLOA, URL is here:

https://alexandria.io/browser/713057

Anyhow the issue is with embedding the PDF - I'd really like to post it (and other writings I haven't uploaded yet) on my website, but the embed doesn't work.

I'd also like to point out that even a non-free PDF is downloadable using the embedded viewer, but I've been told this is a known-issue and that it'll be handled at some point. I'm really not a best-seller and I'm not worried about losing sales or anything lol, just wanted to mention it.

copernicus-mogley commented 7 years ago

Hi @RoguePlanetArt. The PDF appears to be embedding for me ... screenshot from 2017-06-07 13-34-45 Also, when I click on the price to download the PDF, it loads the paywall. So, I'm not entirely clear about what the issue is that you are expressing.

RoguePlanetArt commented 7 years ago

Hi Copernicus, my apologies for the confusion - I was referring to the embed code listed at the bottom of the page, when used to embed the artifact on other websites - I just went to grab a screen-shot from my website, and of course now it's working! Haha, dunno what you guys did, but you're amazing. Thank you!

As for the download thing I mentioned, I was referring to this. https://dl.dropboxusercontent.com/u/36662052/alexandira%20pdf%20embed%20download.PNG

RoguePlanetArt commented 7 years ago

I am also having trouble getting the following artifact to embed on my blog. https://alexandria.io/browser/e13fd0

https://dl.dropboxusercontent.com/u/36662052/alexandria%20embed%20fail.PNG

Cheers, Kris

RoguePlanetArt commented 7 years ago

OK, nm I see there's an error with the embed code generation - got it fixed thanks