search

dlouwers / reactive-consul

Consul client for Scala
MIT License
18 stars 7 forks source link

serviceId <-> serviceName handling #19

Closed sjoerdmulder closed 7 years ago

sjoerdmulder commented 7 years ago

The following example has multiple ServiceDefinition with the same name but different tags, currently this scenario doesnt work and the ServiceBrokerActor at line 70 throws a NoSuchElement exception since the lookup is by name and not by id. In most cases this works because id == name but if name and id differ it was broken; This PR fixes it.

ServiceDefinition("http.service1", "service1", Set("http"))
ServiceDefinition("gprc.service1", "service1", Set("grpc"))