ServiceBroker should be created with unique actor name

[nonsleepr]

Hardcoded name prevents the creation of multiple instances of ServiceBroker.

[dlouwers]

I wouldn't have thought this to be a potential issue. What scenario do you need multiple ServiceBrokers in? Simplest might be to add the option to pass a name that defaults to "default".

[nonsleepr]

Can't recall exact case but I guess I had brokers for different services.

[dlouwers]

Ok, well all my constructors are convenience methods. You can easily take control like so:

def apply(systemName: String, consulAddress: URL, services: Set[ConnectionStrategy]): ServiceBroker = {
    implicit val rootActor = ActorSystem(systemName)
    val httpClient = new AkkaHttpConsulClient(consulAddress)
    ServiceBroker(rootActor, httpClient, services)
  }

Thank you for your feedback.

[nonsleepr]

That's what I did in the end.

[dlouwers]

Good. Do you feel that is fine or that is such a common use case there should be a special constructor for it?

[nonsleepr]

It probably is. The thing is, I followed the example to create service provider (I needed to have two providers for different services) and stumbled upon that problem.