search

dlowe-net / local-time

Time manipulation library for Common Lisp
Other
102 stars 43 forks source link

Adding subzone lookup #89

Closed egao1980 closed 4 years ago

egao1980 commented 4 years ago

Currently there's no sub-zone lookup that prevents parsing dates with subzone abbrev like "Thursday, 2 April 2020, 11:30:57 BST"

Lookup results are sorted by most common use first. So BST will map to London and European British island followed by other timezones like Pacific/Midway. This will allow more accurate parsing of dates.

dlowe-net commented 4 years ago

This looks very useful! Could you update the documentation to include the new function? Also, add yourself in the CREDITS file.

egao1980 commented 4 years ago

It needs a bit of work since the subzones are actually in ascending chronological order.

egao1980 commented 4 years ago

Submitting for early review. Please check if it falls in line with general library style. I'll focus on tests as this is no longer a trivial change :)

egao1980 commented 4 years ago

Ping. I'm available if there are any questions on this one

dlowe-net commented 4 years ago

I would love the tzdata update, but probably not in this PR. Could you shift it to another one?

egao1980 commented 4 years ago

Thanks for responding. I've removed TZdata update from this PR - will submit the it as a separate one.

dlowe-net commented 4 years ago

Thanks for the feature!