Harmonize popup properties and Publish popup events - Githubissues

dlr-eoc / ukis-frontend-libraries

A collection of angular ui-components, services, interfaces... to help you create geospatial mapping applications for the web.

Apache License 2.0

17 stars 4 forks source link

Harmonize popup properties and Publish popup events #193

Closed boeckMt closed 1 year ago

boeckMt commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/dlr-eoc/ukis-frontend-libraries/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] The Project is building and passes all tests without errors

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:

160
191

What is the new behavior?

Popup properties are now harmonized and all popups get IPopupParams so the user has a consistent interface. closes #160
Events for popups are exposed through a subject MapOlService.popupEvents Subject<IPopupEvent> for all popups that get Layer.popup.asObservable: true. See the example in demo-maps/example-layout. closes #191

Does this PR introduce a breaking change?

Other information

Is it part of one/more packages and which?

@dlr-eoc/map-ol
@dlr-eoc/services-layers
demos