search

dlr-eoc / ukis-pysat

The ukis-pysat package provides generic classes and functions to query, access and process multi-spectral and SAR satellite images
Apache License 2.0
27 stars 8 forks source link

removing download error from EarthExplorer #141

Closed shiwakotisurendra closed 3 years ago

shiwakotisurendra commented 3 years ago

closes #140

codecov-commenter commented 3 years ago

Codecov Report

Merging #141 (bae3a7c) into master (87f1995) will increase coverage by 0.17%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   81.13%   81.31%   +0.17%     
==========================================
  Files          11       11              
  Lines         917      915       -2     
==========================================
  Hits          744      744              
+ Misses        173      171       -2
Flag Coverage Δ
unittests 81.31% <0.00%> (+0.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ukis_pysat/data.py 59.78% <0.00%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87f1995...bae3a7c. Read the comment docs.

shiwakotisurendra commented 3 years ago

did you test this? This looks like product_srcid should be renamed to product_uuid as well, because it does not exist in this case.

Also our comment in line 305 is wrong, it should be GCS instead of AWS.

Please update CHANGELOG as well.

yes i did this and also tested . I got a error at first , but after updating the pylandsat , it worked.