search

dlr-eoc / ukis-pysat

The ukis-pysat package provides generic classes and functions to query, access and process multi-spectral and SAR satellite images
Apache License 2.0
27 stars 8 forks source link

Download Method Conflict in SCIHUB and EARTHEXPLORER #151

Closed shiwakotisurendra closed 3 years ago

shiwakotisurendra commented 3 years ago

Describe the bug when the item is created we set a value for the ID's,

But when we query the hub we take another value of the item ìtem.id for Landsat and ```item. Properties['uuid'] for sentinel to download.

To Reproduce To download we can give the item.id (product "ID") here always and solve this internally.

Expected behavior UKIS_PYSAT download method for SCIHUB and EARTHEXPLORER both should have used eitherproduct_uuid or ``product_id"``` .

fwfichtner commented 3 years ago

please use the product id (item.id), that's more consistant.

shiwakotisurendra commented 3 years ago

But we are using this to download sentinel , which links to sentinelsat.SentinelAPI and they are using product_uuid for download.

fwfichtner commented 3 years ago

You would need to go from item.id to product_uuid. Maybe you can also support both of them, that would be better for compatibility with older versions as well.