Resolve "Enabling "log file and line numbers" flag will break verbosity levels" - [merged] #105

Closed rainman110 closed 10 months ago

In GitLab by @mariusalexander on May 3, 2023, 13:47

Merges 43-enabling-log-file-and-line-numbers-flag-will-break-verbosity-levels -> master

Closes #43

The Helper class for the macros will check if the stream object "can log" and only then proceeds to log the message.

In GitLab by @mariusalexander on May 3, 2023, 13:58

added 2 commits

In GitLab by @mariusalexander on May 3, 2023, 13:58

requested review from @rainman110

In GitLab by @mariusalexander on May 3, 2023, 13:59

requested review from @jensschmeink

In GitLab by @jensschmeink on May 3, 2023, 14:00

That change seems very simple, great!

In GitLab by @jensschmeink on May 3, 2023, 14:00

approved this merge request

In GitLab by @mariusalexander on May 3, 2023, 14:02

Hm the tests no longer seem to work :(

In GitLab by @mariusalexander on May 3, 2023, 14:02

marked this merge request as ready

In GitLab by @rainman110 on May 4, 2023, 04:59

My fault. I needed to rename the unit test CI variable for the exe name due to the cmake transition.

In GitLab by @rainman110 on May 4, 2023, 19:32

I think you should set the verbosity first, otherwise, the test might fail if another earlier test sets the verbosity to high.

In GitLab by @mariusalexander on May 5, 2023, 07:22

added 1 commit

In GitLab by @mariusalexander on May 5, 2023, 07:22

Good catch (y) done in newest commit

In GitLab by @mariusalexander on May 5, 2023, 09:32

added 10 commits

In GitLab by @mariusalexander on May 5, 2023, 09:34

resolved all threads

In GitLab by @mariusalexander on May 5, 2023, 09:36

@rainman110 @jensschmeink Please approve once more

In GitLab by @rainman110 on May 5, 2023, 10:08

approved this merge request

In GitLab by @rainman110 on May 5, 2023, 10:08

mentioned in commit 40b1f321d093f22b14c72376ff3219ffa8ca15ee

dlr-gtlab / gt-logging