search

dlr-gtlab / gt-logging

Basic C++14 logging library based on QsLog
0 stars 0 forks source link

Forward time and logging id to Logging Destination #34

Closed rainman110 closed 10 months ago

rainman110 commented 1 year ago

In GitLab by @mariusalexander on Nov 10, 2022, 14:02

Currently we "hard-code" the format of the logging message:

[ID] [DATE] [LEVEl] <message>

There is the gt::log::Destination::write method, that accepts the message (which is already formatted) as well as the logging level of that message. I think it would be much better to forward date and id to the logging message as well:

class Destination {
    // ...
    virtual void write(Level level, QString id, QDateTime time, QString message) = 0;
};
rainman110 commented 1 year ago

In GitLab by @mariusalexander on Nov 17, 2022, 13:56

created branch 34-forward-time-and-logging-id-to-logging-destination to address this issue

rainman110 commented 1 year ago

In GitLab by @rainman110 on Nov 24, 2022, 14:43

mentioned in commit 32e18f9adb7e50b88e4de4ebffe46d1a08e79197