dlr-gtlab / gt-logging

Basic C++14 logging library based on QsLog
1 stars 1 forks source link

Resolve "Consider using noquote by default" - [merged] #89

Closed rainman110 closed 11 months ago

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Aug 23, 2022, 07:27

Merges 25-consider-using-noqoute-by-default -> master

This MR enables gtDebug().noquote() by default.

Define QS_LOG_USE_QUOTE to reenable the qouting behaviour.

Define QS_LOG_USE_NOSPACE to disable the auto inserted spaces.

Closes #25

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Aug 23, 2022, 07:42

added 1 commit

Compare with previous version

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Aug 23, 2022, 11:04

added 1 commit

Compare with previous version

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Aug 23, 2022, 12:49

marked this merge request as ready

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 10:54

added 2 commits

Compare with previous version

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 10:56

Commented on src/QsLog.h line 74

#ifndef GT_LOG_USE_QUOTE
rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 10:57

resolved all threads

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 10:57

Commented on src/QsLog.h line 74

changed this line in version 4 of the diff

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 10:57

added 1 commit

Compare with previous version

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 11:08

added 1 commit

Compare with previous version

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 11:09

approved this merge request

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 11:09

unapproved this merge request

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 20, 2022, 11:09

requested review from @real-ct-ac and @jensschmeink

rainman110 commented 2 years ago

In GitLab by @jensschmeink on Sep 20, 2022, 11:10

approved this merge request

rainman110 commented 2 years ago

In GitLab by @jensschmeink on Sep 20, 2022, 11:10

I like it. :)

rainman110 commented 2 years ago

In GitLab by @mariusalexander on Sep 26, 2022, 08:35

mentioned in commit cb1217ccf108535db71f8fc0ba31771fce0bac3b