Resolve "Add an ID to the logging output" - [merged]

[rainman110]

In GitLab by @mariusalexander on Sep 16, 2022, 15:12

Merges 28-add-an-id-to-the-logging-output -> master

This MR implements the ability to log an additional identificiation string. One may define GT_MODULE_ID globally at compile to provide a logging ident otherwise nothing will be logged.

Additionally I added gtTraceId, gtDebugId etc. macros for logging a custom ID.

It also fixed a bug in the GT_LOG_LINE_NUMBERS define due to which it was not possible to call methods on the QDebug stream (e.g. gtDebug().nospace()) when the define was set.

Closes #28

[rainman110]

In GitLab by @mariusalexander on Sep 16, 2022, 15:34

added 1 commit

• a90a9364 - added missing space after id

Compare with previous version

[rainman110]

In GitLab by @mariusalexander on Sep 19, 2022, 11:11

Example output in GTlab:

[rainman110]

In GitLab by @mariusalexander on Sep 19, 2022, 11:30

Example output if GT_LOG_LINE_NUMBERS has been defined:

[rainman110]

In GitLab by @mariusalexander on Sep 19, 2022, 11:42

added 1 commit

• 9659390e - fixed logging linenumbers impl

Compare with previous version

[rainman110]

In GitLab by @mariusalexander on Sep 19, 2022, 11:50

marked this merge request as ready

[rainman110]

In GitLab by @mariusalexander on Sep 19, 2022, 11:53

Commented on src/QsLog.h line 79

Log nothing if id was not set:

            , buffer{id.isEmpty() ? QString{}:
                                    QChar{'['} + std::move(id) + QString{"] "}}

[rainman110]

In GitLab by @mariusalexander on Sep 19, 2022, 12:00

Commented on src/QsLog.h line 42

Abort compilation if QS_LOGGING_ID was not set:

#error QS_LOGGING_ID must be defined globally when using QsLog. \
       Please define the macro using -DQS_LOGGING_ID =<logging_id>

Will show as:

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 10:52

Commented on src/QsLog.h line 79

changed this line in version 4 of the diff

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 10:52

Commented on src/QsLog.h line 42

changed this line in version 4 of the diff

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 10:52

added 1 commit

• c07e5fc5 - renamed logging macro, logging macro is now mandatory

Compare with previous version

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 10:55

added 1 commit

• ec32e4c4 - updated changelog

Compare with previous version

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 10:57

Commented on src/QsLog.h line 79

applied in a separate commit

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 10:57

Commented on src/QsLog.h line 42

applied in a separate commit

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 10:57

resolved all threads

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 11:00

added 1 commit

• 49fd9f80 - fixed typo

Compare with previous version

[rainman110]

In GitLab by @mariusalexander on Sep 20, 2022, 11:16

added 1 commit

• 66f71c30 - fix

Compare with previous version

[rainman110]

In GitLab by @mariusalexander on Sep 23, 2022, 14:58

mentioned in merge request gtlab-coredev/gtlab!210

[rainman110]

In GitLab by @mariusalexander on Sep 26, 2022, 12:15

added 9 commits

• 66f71c30...cb1217cc - 2 commits from branch master
• b64136c8 - initial draft
• 4648fa46 - added missing space after id
• bc9cf889 - fixed logging linenumbers impl
• f2147ac5 - renamed logging macro, logging macro is now mandatory
• e33169e0 - updated changelog
• 3da2b5c3 - fixed typo
• ee17c8dc - fix

Compare with previous version

[rainman110]

In GitLab by @mariusalexander on Sep 27, 2022, 08:02

requested review from @jensschmeink and @rainman110

[rainman110]

In GitLab by @mariusalexander on Sep 30, 2022, 09:27

added 10 commits

• 35045910 - initial draft
• a90a9364 - added missing space after id
• 9659390e - fixed logging linenumbers impl
• c07e5fc5 - renamed logging macro, logging macro is now mandatory
• ec32e4c4 - updated changelog
• 49fd9f80 - fixed typo
• 66f71c30 - fix
• e5cd78f2 - Merge branch '28-add-an-id-to-the-logging-output' of...
• 393127b0 - reverted that logging may only be used if GT_MOUDLE_ID was set
• d4078c41 - updated changelog

Compare with previous version

[rainman110]

In GitLab by @mariusalexander on Oct 4, 2022, 12:11

Commented on src/QsLog.h line 77

                        QString id = GT_LOG_TO_STR(GT_MODULE_ID)) :

[rainman110]

In GitLab by @mariusalexander on Oct 4, 2022, 12:11

resolved all threads

[rainman110]

In GitLab by @mariusalexander on Oct 4, 2022, 12:11

Commented on src/QsLog.h line 77

changed this line in version 10 of the diff

[rainman110]

In GitLab by @mariusalexander on Oct 4, 2022, 12:11

added 1 commit

• f39b4729 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[rainman110]

In GitLab by @jensschmeink on Oct 10, 2022, 12:32

approved this merge request

[rainman110]

In GitLab by @mariusalexander on Oct 10, 2022, 14:18

mentioned in commit 3d4881c07da46c0003434ec0fee7f0e6dc500169