dlr-gtlab / gtlab-core

GTlab Core Framework
https://www.gtlab.de
Other
7 stars 2 forks source link

Highlighting Changing of a Sub-Sub-Property #1126

Closed bjoernTWK closed 5 months ago

bjoernTWK commented 8 months ago

If a Sub-Property is placed under a ModeTypeProperty and the value is changed via a calculator, the property is not highlighted

jensschmeink commented 7 months ago

@bjoernTWK do you have an example or a screenshot? That could help to find the problem

bjoernTWK commented 7 months ago

@bjoernTWK do you have an example or a screenshot? That could help to find the problem

I have no screenshot for this behavior. Is it not possible to re-produce the issue (or is there another reason for the request)?

jensschmeink commented 7 months ago

Just to reproduce the error faster.

jensschmeink commented 6 months ago

This problem might be related to the issue #191

rainman110 commented 6 months ago

@bjoernTWK please provide a specific example. I don't yet understand, how the properties need to be arranged.

bjoernTWK commented 6 months ago

As an example I've choosen the VGVcompressor:

bjoernTWK commented 6 months ago

@rainman110 I hope this example is helpful

rainman110 commented 5 months ago

@bjoernTWK I did an analysis of the problem.

The reason is the following. GTlab is currently sensitive on the order of the registration of properties and subproperties. In particular, subproperties need to be registered, before the main property is registered to the object.

In this case in the Performance Module, the order is incorrect, the main property in registered too early and need to be fixed there.

Here's a best practice on how to register properties:

I will create an issue for the 2.1 release series, that we change the way, how subproperties change signals are escalated to the top, such that the order of registering does not matter anymore.