Enable console application to use collections

dlr-gtlab / gtlab-core

GTlab Core Framework

https://www.gtlab.de

Other

7 stars 2 forks source link

Enable console application to use collections #1134

Closed jensschmeink closed 5 months ago

jensschmeink commented 8 months ago

Description

The console application now uses the GtApplication and not only the GtCoreApplication. This was required as the collections had been read from the interfaces in the mdiLauncher which is not accessible in the CoreApplication. This is a work around as the core application should normally depend on GUI elements

How Has This Been Tested?

The colleague who asked for the change used it successfully.

Checklist:

[ ] A test for the new functionality was added (if applicable).
[ ] All tests run without failure.
[ ] The changelog has been extended, if this MR contains important changes from the users's point of view.
[ ] The new code complies with the GTlab's style guide.
[ ] New interface methods / functions are exported via EXPORT. Non-interface functions are NOT exported.
[ ] The number of code quality warnings is not increasing.

rainman110 commented 8 months ago

@real-ct-ac Can you foresee the side-effects when using GtApplication istead of CoreApplication for the Console mode? Is there any changed logic that will lead to a different runtime behaviour (other than registering the MDI stuff)?

jensschmeink commented 8 months ago

There will be some registration functions for widgets which might be started. Therefore the starting process might be a bit longer. But JHä did not report about any other problematic issues.

real-ct-ac commented 7 months ago

Hast anyone tested it on Linux?

rainman110 commented 7 months ago

Hast anyone tested it on Linux?

I did not. But good point. I suppose, we anyhow need an x server etc (we already did before)

jensschmeink commented 7 months ago

Hast anyone tested it on Linux?

Me neither.

rainman110 commented 6 months ago

How should be proceed here? We need to test GTlab on linux. Also, this change should be temporary, since it enforces even more the dependency to the GUI.

jensschmeink commented 6 months ago

It needs to be discussed if this temporary fix should be part of GTlab 2-0-7

OliverKunc commented 6 months ago

We would appreciate it because we need this feature to run our tests

jensschmeink commented 6 months ago

@OliverKunc do you use it on linux? We could give you the executable of this PR and you could test the specific usecase. That would be perfect

OliverKunc commented 6 months ago

@jensschmeink We don't run the tests on Linux yet but we hope to do so soon. Executable would be great.

jensschmeink commented 5 months ago

@rainman110 @real-ct-ac initial tests on linux did not show any problems (e.g. no appearing widgets). But the logging should be cleaned up as there is some GUI specific logging:
"### Registered executor 'ProcessRunner'"
"No shortcuts registered!"
"No shortcut registered for openProject"
...

jensschmeink commented 5 months ago

@rainman110 as we discussed this PR should be merged. An approval is needed