[CHANGE] - Recude the undo/redo command scope when setting the value of GtPropertyFileChooserEditor

dlr-gtlab / gtlab-core

GTlab Core Framework

https://www.gtlab.de

Other

7 stars 2 forks source link

[CHANGE] - Recude the undo/redo command scope when setting the value of GtPropertyFileChooserEditor #1187

Open mariusalexander opened 4 months ago

mariusalexander commented 4 months ago

Summary

It seems to me that the file chooser property uses a project wide scope for the undo/redo command when a object wide scope would suffice. This could reduce lag spikes for larger projects

See https://github.com/dlr-gtlab/gtlab-core/blob/bca377172d6df52e1ece73d743c7ac3067735f30/src/gui/dock_widgets/properties/editors/gt_propertyfilechoosereditor.cpp#L100-L112

Impact on the codebase

Minimal

Current workarounds

None.

jensschmeink commented 4 months ago

There would be the need to access the object which registered the property to have a better scope. This is not accessable currently. A refactoring is required to pass the needed object to the editor.