Currently, all shortcuts are defined in the core settings. This is bad, as it ties the core library to QtGui, requiring a full X-Server stack.
IMHO, shortcuts should be registered in the APP instead.
Impact on the codebase
Maybe we need to adapt the settings.
Current workarounds
-
First analysis
the class GtShortCut and GtShortCutSettingsData use QKeySequence which relies on the QtGui library.
moving shortcuts to Gui would be sensible, but there is a problem:
Many modules register the shortcuts in the module::init phase, hence also in batch mode. Moving shortcuts to gui would break things
An alternative would be, to find a replacement for QKeySequence instead. We could keep the shortcut system in core, but without needing the QtGui library.
Summary
Currently, all shortcuts are defined in the core settings. This is bad, as it ties the core library to QtGui, requiring a full X-Server stack.
IMHO, shortcuts should be registered in the APP instead.
Impact on the codebase
Maybe we need to adapt the settings.
Current workarounds
-
First analysis
GtShortCutandGtShortCutSettingsDatauseQKeySequencewhich relies on the QtGui library.module::initphase, hence also in batch mode. Moving shortcuts to gui would break thingsAn alternative would be, to find a replacement for
QKeySequenceinstead. We could keep the shortcut system in core, but without needing the QtGui library.