Fix moving process element bug

dlr-gtlab / gtlab-core

GTlab Core Framework

https://www.gtlab.de

Other

7 stars 2 forks source link

Closed jensschmeink closed 4 months ago

jensschmeink commented 4 months ago

Closes #1213

[ ] A test for the new functionality was added (if applicable).
[ ] All tests run without failure.
[ ] The changelog has been extended, if this MR contains important changes from the users's point of view.
[ ] The new code complies with the GTlab's style guide.
[ ] New interface methods / functions are exported via EXPORT. Non-interface functions are NOT exported.
[ ] The number of code quality warnings is not increasing.

rainman110 commented 4 months ago

@jensschmeink Please rebase to the current master to enable cppcheck

jensschmeink commented 4 months ago

The move elements function is now too long. Can you please subdivide it into smaller sub-functions. It is currently very hard to read and understand.

I divided parts of the function in seperate functions

jensschmeink commented 4 months ago

@rainman110 after the warning is hidden now, can we merge?

jensschmeink commented 4 months ago

@rainman110 I added the requested comments.