[CHANGE] - Refactor API of GtGrid class to expose members and allow customization of minor/major gird lines settings - Githubissues

dlr-gtlab / gtlab-core

GTlab Core Framework

https://www.gtlab.de

Other

7 stars 2 forks source link

[CHANGE] - Refactor API of GtGrid class to expose members and allow customization of minor/major gird lines settings #1224

Open mariusalexander opened 3 months ago

mariusalexander commented 3 months ago

Summary

IMO GtGrid has multiple issues that needs addressing to improve its usability:

For starters, grid height and width are poorly named (IMHO) since these properties refer to the spacing between horizontal and vertical lines. This should be renamed to horizontal/vertical-advance for example.
The GtGrid class currently also provides not getters for the "height" and "width"
The minor gird lines cannot be customized whatsoever

Impact on the codebase

API/ABI change

Current workarounds

One has to remember the grid height/width manually in code. This is a no-go