🐛 [BUG] - GtAbstractProperty::categoryToString() should be marked const

dlr-gtlab / gtlab-core

GTlab Core Framework

https://www.gtlab.de

Other

7 stars 2 forks source link

🐛 [BUG] - GtAbstractProperty::categoryToString() should be marked const #1256

Open mariusalexander opened 2 months ago

mariusalexander commented 2 months ago

Summary

GtAbstractProperty::categoryToString() is not marked const.

Expected Behaviour

GtAbstractProperty::categoryToString() should be marked const

Reproduction steps

https://github.com/dlr-gtlab/gtlab-core/blob/d3ec67badd1be1d1a77ab0dc2a842aeec3eab56e/src/dataprocessor/property/gt_abstractproperty.cpp#L81C1-L91C2

Screenshots

No response

Logs

No response

GTlab environment

GTlab Version: 2.0.7

OS

Windows

mariusalexander commented 2 months ago

Maybe we can rename the function as well. Something like categoryString would be more fitting. That way we can also avoid an ABI change. Then again, comes the question whether we need the category type (Main, Custom) at all.