search

dlr-gtlab / gtlab-core

GTlab Core Framework
https://www.gtlab.de
Other
7 stars 2 forks source link

fix.: disabled switching project to same project while task is running #1282

Closed NitenIchiry closed 2 months ago

NitenIchiry commented 2 months ago

Projects cannot be switched while task is running. This PR removes the possibility to switch to the same project while a task is running/does not show the project switch warning in this case.

rainman110 commented 2 months ago

@NitenIchiry When creating PRs, please don't remove the default PR checklist for the reviewer. Normally, you should have seen it, when initially created the PR.

Changes that are apparent to the user, should also be added to the changelog.

Could you thus please extend the changelog.

NitenIchiry commented 2 months ago

I am very sorry. I did not like the default check-list in this case. But I will extend the checklist just now.

NitenIchiry commented 2 months ago

I will merge if you have no issues with this.

rainman110 commented 2 months ago

No, please don't merge yourelf. I'd like to clean the git history first

rainman110 commented 2 months ago

Please avoid merging the master into a feature branch.

NitenIchiry commented 2 months ago

Oh that happened because this was derived from the master. I did not think about it 😢

NitenIchiry commented 2 months ago

Just thought there would not be another 2.0.X

rainman110 commented 2 months ago

Don't worry. This can all be fixed ;)