search

dlr-gtlab / gtlab-core

GTlab Core Framework
https://www.gtlab.de
Other
7 stars 2 forks source link

🐛 [BUG] - Serialization should be deterministic #1291

Open OliverKunc opened 4 days ago

OliverKunc commented 4 days ago

Summary

Saving a project can lead to changes of XML serializations of objects that were not changed. These XML changes are due to different ordering of the tag attributes.

Expected Behaviour

Unchanged objects should have constant serialization.

Reproduction steps

Not always reproducible, but occurs quite often.

- Commit a project to a git repository
- Change some little thing, e.g. some property of an object
- Save the project
- git diff

Screenshots

grafik

Logs

No response

GTlab environment

GTlab Version: 2.0.9

OS

Windows

rainman110 commented 4 days ago

@OliverKunc you are right, the error is the "false" flag in the first line of https://github.com/dlr-gtlab/gtlab-core/blob/542e47d4adab337f7c6e7558508b882b719626fc/src/core/process_management/gt_taskgroup.cpp#L503-L507

🤦

OliverKunc commented 4 days ago

I am glad this is an easy fix :-)