Tasks get lost after saving project via "Save As"

[rainman110]

In GitLab by @bjoernTWK on Oct 23, 2023, 08:09

Summary

If a project is duplicated with the save-as-function (CTRL+SHIFT+S), the processes/calculators are not availabel in the new project (in one case GTlab crashed via the project)

Steps to reproduce

How can we reproduce the issue - this is very important!

• Open a project
• Duplicate the project via the save-as-function
• Open duplicated project

[jensschmeink]

@bjoernTWK can you explain which problems occurred and which calculators were affected?

[bjoernTWK]

@bjoernTWK can you explain which problems occurred and which calculators were affected?

In my case the tasks are not copied in the new project (the folder was empty after the process -> maybe the external process element saving path is not applied correctly)

[rainman110]

Bug Analysis

• The new project path is not known at the moment of saving to a new project
• To be known, a API refactoring is required

[rainman110]

I have to withdraw my last analysis. The new path is known.

A multitude of problems come together here, I try to note them here:

1. First the project is duplicated using memento->clone(). The "ProcessData" object cannot be cloned, as it does not have an invokable default constructor. Hence, the ProcessData node is a dummy and will be returned as a nullptr, when quering it by its classname.
2. By providing a Q_INVOKABLE constructor to GtProcessData, issue 1. can be fixed. Still, the tasks cannot be saved, as the task group is still internally not initialized. Practially this means, that this internal information is not cloned.

Even if we fix this, only the active task group would be saved, as it is only part of the project. IMHO, all tasks need to be copied though, when saving a project to a different location.

@real-ct-ac What do you suggest here? How should we proceed.

[rainman110]

The easiest way to "fix" it, is to simple copy the task files in "duplicateProject" via

    gt::filesystem::copyDir(
        QDir(oldDirectory.absoluteFilePath(QStringLiteral("tasks"))),
        QDir(newDirectory.absoluteFilePath(QStringLiteral("tasks"))),
        gt::filesystem::Recursive,
        QRegularExpression(R"(.*\.gttask|index.json)"));

The copied files will be automatically read-in when the project is opened again. They won't be copied during clone-only though. It works, but I am not sure though, whether this is the correct way to do. @real-ct-ac Pinging you here ;)

[rainman110]

One more thing. Only copying the task files does not work: What, if the tasks have been changed or extended.

Then, we need to

• First copy the old tasks directory
• Save the new (changed) tasks into the new directory.

Thus, we need to make the processdata node copyable.