dlr-gtlab / python-module

GTlab Module for embadding Python into GTlab
0 stars 0 forks source link

Cmake support - [merged] #537

Closed rainman110 closed 4 months ago

rainman110 commented 11 months ago

_Merges cmakesupport -> master

This changes the build system of the python module to cmake

rainman110 commented 11 months ago

marked this merge request as draft

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 1 commit

Compare with previous version

rainman110 commented 11 months ago

added 2 commits

Compare with previous version

rainman110 commented 11 months ago

added 2 commits

Compare with previous version

rainman110 commented 11 months ago

marked this merge request as ready

rainman110 commented 11 months ago

requested review from @jensschmeink

rainman110 commented 11 months ago

requested review from @marvinoe21

rainman110 commented 11 months ago

In GitLab by @jensschmeink on Dec 11, 2023, 06:57

Commented on src/module/CMakeLists.txt line 198

Just a question: how can GTlab::Core be a private dependency when it's components are linked in some headers? (e.g. task)

rainman110 commented 11 months ago

In GitLab by @jensschmeink on Dec 11, 2023, 06:58

mentioned in commit 4dd92270cd46747c9ecb9b7136fa9df2814e6291

rainman110 commented 11 months ago

In GitLab by @jensschmeink on Dec 11, 2023, 06:59

@rainman110 @marvinoe21 Sorry, i took the wrong button and instead of an approval I already merged the MR :(. If there are any open things in the review of course I'll fix it!

rainman110 commented 11 months ago

In GitLab by @jensschmeink on Dec 11, 2023, 07:33

@rainman110 There seems to be a problem in the packaging job.

rainman110 commented 11 months ago

You are right, good catch. Typical copy paste problem from dataanalytics :laughing:

rainman110 commented 11 months ago

Right. I skipped the debug build on windows for gtlab 1.7 due to some python packaging issues (I was too lazy to fix it). This seems to be the reason, why the packagng step cannot find the debug libs.