Resolve "Add decorator functions to access structproperties in a nice way" - [merged] - Githubissues

dlr-gtlab / python-module

GTlab Module for embadding Python into GTlab

0 stars 0 forks source link

Resolve "Add decorator functions to access structproperties in a nice way" - [merged] #544

Closed rainman110 closed 4 months ago

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 07:08

Merges 254-add-decorator-functions-to-access-structproperties-in-a-nice-way -> master

Closes #254

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 07:21

added 1 commit

64155ad0 - basic wrapper for struct container

Compare with previous version

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 07:22

marked this merge request as ready

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 07:22

approved this merge request

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:00

Commented on src/module/utilities/gtpy_decorator.h line 362

#if GT_VERSION >= 0x020000

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:00

Commented on src/module/utilities/gtpy_decorator.h line 392

#endif

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:01

Commented on src/module/utilities/gtpy_decorator.cpp line 900

#if GT_VERSION >= 0x020000

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:01

Commented on src/module/utilities/gtpy_decorator.cpp line 953

#endif

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

Commented on src/module/utilities/gtpy_decorator.cpp line 27

#include "gt_project.h"
#include "gt_task.h"
#include "gt_coreprocessexecutor.h"
#include "gt_calculator.h"
#include "gt_objectlinkproperty.h"
#include "gt_abstractrunnable.h"
#if GT_VERSION >= 0x020000
#include "gt_structproperty.h"
#include "gt_propertystructcontainer.h"
#endif

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

resolved all threads

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

resolved all threads

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

resolved all threads

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

resolved all threads

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

resolved all threads

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

Commented on src/module/utilities/gtpy_decorator.h line 362

changed this line in version 2 of the diff

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

Commented on src/module/utilities/gtpy_decorator.h line 392

changed this line in version 2 of the diff

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

Commented on src/module/utilities/gtpy_decorator.cpp line 900

changed this line in version 2 of the diff

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

Commented on src/module/utilities/gtpy_decorator.cpp line 953

changed this line in version 2 of the diff

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

Commented on src/module/utilities/gtpy_decorator.cpp line 27

changed this line in version 2 of the diff

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:02

added 1 commit

8e41f5f7 - try to fix compatibility to gtlab 1-7

Compare with previous version

rainman110 commented 9 months ago

In GitLab by @jensschmeink on Feb 8, 2024, 14:58

requested review from @marvinoe21 and @real-ct-ac

rainman110 commented 8 months ago

In GitLab by @jensschmeink on Mar 5, 2024, 12:21

requested review from @rainman110

rainman110 commented 8 months ago

I would rename this to getPropertyContainerVal or similar. I would remove the word "struct".

rainman110 commented 8 months ago

?

rainman110 commented 8 months ago

Same as above, use the name property container.

rainman110 commented 8 months ago

In GitLab by @jensschmeink on Mar 5, 2024, 14:31

Commented on src/module/utilities/gtpy_decorator.h line 376

changed this line in version 3 of the diff

rainman110 commented 8 months ago

In GitLab by @jensschmeink on Mar 5, 2024, 14:31

Commented on src/module/utilities/gtpy_decorator.h line 559

changed this line in version 3 of the diff

rainman110 commented 8 months ago

In GitLab by @jensschmeink on Mar 5, 2024, 14:31

Commented on src/module/utilities/gtpy_decorator.h line 390

changed this line in version 3 of the diff

rainman110 commented 8 months ago

In GitLab by @jensschmeink on Mar 5, 2024, 14:31

added 1 commit

69383ad7 - rename functions as suggested

Compare with previous version

rainman110 commented 8 months ago

In GitLab by @jensschmeink on Mar 5, 2024, 14:32

@rainman110 I cleaned up the code and renamed as you suggested

rainman110 commented 8 months ago

approved this merge request

rainman110 commented 8 months ago

mentioned in commit 7717d9e9095013c7453d465dfa66875d1a23de22