Implemented C++ RAII wrapper to reduce memleaks - [merged]

[rainman110]

_Merges python_cppapi -> master

This refactoring provides RAII style wrappers for PyObject. In fact, using these changes, I could reduce many memory leaks (see #264). This wrapper should make the manual refcounting unnecessary and hence should reduce the number of potential programming errors, making the code also much more thread safe.

I tested the code using address sanitizer, showing no more memory leaks.

• Added gtpypp, which is a low level C++ wrapper around the Python C API
• This also closes the issue, that a GTObject cannot be passed into shared functions (Closes #256)
• Shared functions for testing have been added
• Fixed ContextManager::getVariable for GtObjects (Closes #263)
• Started some unit tests

Closes #256, #263, #264

[rainman110]

added 1 commit

• 3c6cba50 - Further work

Compare with previous version

[rainman110]

added 1 commit

• 23095ef0 - Further work

Compare with previous version

[rainman110]

added 1 commit

• 7739b822 - Further work

Compare with previous version

[rainman110]

added 1 commit

• 8612f8cc - More work in CPP refactoring

Compare with previous version

[rainman110]

added 1 commit

• 2cff4c06 - Finished most of PyPPObject transition

Compare with previous version

[rainman110]

added 1 commit

• 4337e65c - Some API cleanup

Compare with previous version

[rainman110]

added 1 commit

• ddb89eaf - Fixup

Compare with previous version

[rainman110]

added 1 commit

• 06a60d2e - Fixed invalid gil locking

Compare with previous version

[rainman110]

added 1 commit

• 252892b8 - More refactoring to PyPP

Compare with previous version

[rainman110]

added 3 commits

• cb258dd2 - Fixup
• 4195ace7 - Fixed conversion of GtObjects to QVariant
• e8cecdec - Added some shared functions for testing

Compare with previous version

[rainman110]

added 1 commit

• 71ce4e16 - Added some shared functions for testing

Compare with previous version

[rainman110]

added 17 commits

• 71ce4e16...7717d9e9 - 5 commits from branch master
• 7717d9e9...b349b1b2 - 2 earlier commits
• 3bcba5fb - Further work
• b20df4eb - More work in CPP refactoring
• 78120dde - Finished most of PyPPObject transition
• 4c046c8c - Some API cleanup
• adaa31ba - Fixup
• 11e9026e - Fixed invalid gil locking
• c65f8911 - More refactoring to PyPP
• 4bcbc47a - Fixup
• 433cc511 - Fixed conversion of GtObjects to QVariant
• 2323df88 - Added some shared functions for testing

Compare with previous version

[rainman110]

marked this merge request as ready

[rainman110]

added 4 commits

• 3794d4c5 - Started working on a c++ python api
• a6ae7a06 - Fixed invalid gil locking
• a5fdbee9 - Fixed conversion of GtObjects to QVariant
• 1c578e08 - Added some shared functions for testing

Compare with previous version

[rainman110]

added 8 commits

• 1c578e08...8c2223e3 - 4 commits from branch master
• 90b3a4d1 - Started working on a c++ python api
• 532dbe93 - Fixed invalid gil locking
• d62120a0 - Fixed conversion of GtObjects to QVariant
• 4df7619b - Added some shared functions for testing

Compare with previous version

[rainman110]

added 2 commits

• 664304b2 - Started with some unit tests
• da1b3c05 - Fixed python gtobject to variant conversion

Compare with previous version

[rainman110]

added 1 commit

• 712ccbf9 - Try to fix tests

Compare with previous version

[rainman110]

In GitLab by @marvinoe21 on Mar 13, 2024, 10:37

Commented on src/module/utilities/pythonextensions/gtpy_propertysetter.h line 19

In a Python Task script create a calculator and call a setter method to set a property. E.g.:

pythonScriptEditor = GtpyScriptCalculator("Python Script Editor")
pythonScriptEditor.setScript("print('Hello')")

In GtpyExtendedWrapper_getattro this function is called to create setter methods for GtProperties of GtObjects.

[rainman110]

In GitLab by @marvinoe21 on Mar 13, 2024, 10:43

Commented on src/module/utilities/pythonextensions/gtpy_propertysetter.cpp line 213

@rainman110 You're right! It looks like a leak.

[rainman110]

In GitLab by @marvinoe21 on Mar 13, 2024, 10:59

Commented on src/module/gt_python.cpp line 302

Should these shared functions be merged into the master?

[rainman110]

I would say yes. They are only active in dev mode. Can be used for testing.

[rainman110]

resolved all threads

[rainman110]

changed this line in version 19 of the diff

[rainman110]

changed this line in version 19 of the diff

[rainman110]

added 1 commit

• 7e13be9b - Remaining cleanup

Compare with previous version

[rainman110]

mentioned in commit 17787a89e7f460a22c7d972c60727c2b2dc3e704