Resolve "Footprint via python tasks" - [merged] #551

Closed rainman110 closed 4 months ago

In GitLab by @schn_bo on Apr 10, 2024, 10:50

Merges 269-footprint-via-python-tasks -> master

Closes #269

In GitLab by @schn_bo on Apr 10, 2024, 10:52

added 1 commit

3fbab26a - add fuction for footprint

Compare with previous version

In GitLab by @schn_bo on Apr 10, 2024, 10:55

Commented on src/module/utilities/gtpy_decorator.h line 198

@rainman110 I've implemented a first solution ... I'm not happy with the needed GtObject for calling the function. Is there a way to implement the function without a type definition?

In GitLab by @schn_bo on Apr 10, 2024, 10:56

requested review from @rainman110

You should pass GtProject instead as an argument! Isn't it possible. Look at isOpen(GtProject* ).

You should also add the core version to the footprint

Also, the footprint should only return the modules used by the project

In GitLab by @schn_bo on Apr 11, 2024, 12:45

Commented on src/module/utilities/gtpy_decorator.h line 198

If I use the GtProject-Object (was also my first thought) I cannot use it within the python task (or is there also a getter for the project available -> currentProject is not callable)

In GitLab by @schn_bo on Apr 11, 2024, 15:33

Commented on src/module/utilities/gtpy_decorator.h line 198

changed this line in version 2 of the diff

In GitLab by @schn_bo on Apr 11, 2024, 15:33

added 1 commit

e0f2ab7c - add bool for module infotmation selection

Compare with previous version

In GitLab by @schn_bo on Apr 17, 2024, 07:22

added 1 commit

fe8bf7f2 - add core version

Compare with previous version

In GitLab by @schn_bo on Apr 17, 2024, 07:25

Commented on src/module/utilities/gtpy_decorator.cpp line 1389

@rainman110 Is this the correct name? I've adapted it from the GUI -> 'About GTlab'

In the project xml, the footprint for the core is this

<core-ver>2.0.5</core-ver>

So maybe just name it core.

In GitLab by @schn_bo on Apr 17, 2024, 10:05

Commented on src/module/utilities/gtpy_decorator.cpp line 1390

    retVal.insert("Core",
                  QString(GtVersionNumber(GT_VERSION_MAJOR,

In GitLab by @schn_bo on Apr 17, 2024, 10:05

Commented on src/module/utilities/gtpy_decorator.cpp line 1389

changed this line in version 4 of the diff

In GitLab by @schn_bo on Apr 17, 2024, 10:05

added 1 commit

eacc15ff - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

In GitLab by @schn_bo on Apr 17, 2024, 10:06

Commented on src/module/utilities/gtpy_decorator.cpp line 1389

@rainman110 Done

In GitLab by @schn_bo on Apr 19, 2024, 05:37

requested review from @rainman110

In GitLab by @schn_bo on Apr 24, 2024, 15:36

@rainman110 Could you check the code again? -> Do you have a better idea how to realize the access via the Python task? Otherwise I would keep the solution with the GtObject ;-)

I am gonna check, if we can get rid of the gtobject argument.

changed this line in version 5 of the diff