Resolve "Decorator to set object link properties has problems with heritage" - [merged]

[rainman110]

In GitLab by @jensschmeink on May 29, 2024, 10:24

Merges 279-decorator-to-set-object-link-properties-has-problems-with-heritage -> master

Closes #279

[rainman110]

In GitLab by @jensschmeink on May 29, 2024, 10:46

added 1 commit

• fadf422c - small adaptions to fix usage of object link properties

Compare with previous version

[rainman110]

In GitLab by @jensschmeink on May 29, 2024, 10:56

Commented on CMakeLists.txt line 27

The find package is only needed for GTlab version < 2.0

[rainman110]

In GitLab by @jensschmeink on May 29, 2024, 11:00

added 1 commit

• 5d09f9b2 - add compatibility for gtlab < 2

Compare with previous version

[rainman110]

In GitLab by @jensschmeink on Jun 4, 2024, 11:19

requested review from @rainman110

[rainman110]

In GitLab by @jensschmeink on Jun 4, 2024, 11:19

marked this merge request as ready

[rainman110]

In GitLab by @jensschmeink on Jun 4, 2024, 11:20

@rainman110 this MR is necessary as the python decorator decided which objects to accept in an object link property by its own and not by the latest impementation

[rainman110]

approved this merge request

[rainman110]

added 8 commits

• 5d09f9b2...31627413 - 7 commits from branch master
• 335ce2d6 - small adaptions to fix usage of object link properties

Compare with previous version

[rainman110]

reset approvals from @rainman110 by pushing to the branch

[rainman110]

added 1 commit

• bbea4f80 - small adaptions to fix usage of object link properties

Compare with previous version

[rainman110]

added 1 commit

• d9b2f710 - Updated changelog

Compare with previous version

[rainman110]

@jensschmeink Irgendwie baut das nicht mehr mit 1.7. Kannst du mal schecken? ich habe eigentlich nur die Cmake Änderungen Rückgängig gemacht (die sind schon im master) und gerebased.

[rainman110]

In GitLab by @jensschmeink on Jun 5, 2024, 08:55

@rainman110 You have removed the ifdef for 2-0 and 1-7. There had been some extensions in the objectlink property which are not accessable in GTlab 1-7

[rainman110]

Oh, I removed the commit regarding CMake. So I suppose the ifdefs were part of this commit :face_palm: :laughing: ?

[rainman110]

In GitLab by @jensschmeink on Jun 5, 2024, 09:05

added 3 commits

• fadf422c - small adaptions to fix usage of object link properties
• 5d09f9b2 - add compatibility for gtlab < 2
• fae50dc4 - update

Compare with previous version

[rainman110]

In GitLab by @jensschmeink on Jun 5, 2024, 09:09

added 4 commits

• fae50dc4...a92e1ee7 - 3 commits from branch master
• 7a4c1eca - Merge branch 'master' into '279-decorator-to-set-object-link-properties-has-problems-with-heritage'

Compare with previous version

[rainman110]

In GitLab by @jensschmeink on Jun 5, 2024, 09:12

@rainman110 It's running now. Please check for approval.

[rainman110]

approved this merge request

[rainman110]

mentioned in commit a15cb9774f957d8034330ac8b4b40dcad0bc02df