dls-controls / aioca

Asynchronous Channel Access client for asyncio and Python using libca via ctypes

Apache License 2.0

6 stars 3 forks source link

Remove import from future that breaks support for python 3.6 #19

Closed EmilioPeJu closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #19 (6df093b) into master (1aae5a4) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 6df093b differs from pull request most recent head 76b1bf7. Consider uploading reports for the commit 76b1bf7 to get more accurate results

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          408       407    -1     
=========================================
- Hits           408       407    -1

Impacted Files	Coverage Δ
aioca/_catools.py	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1aae5a4...76b1bf7. Read the comment docs.

EmilioPeJu commented 2 years ago

The maximum version of numpy in pypi is 1.19.5, I guess I would need to recreate Pipefile.lock

thomascobb commented 2 years ago

Yes, any numpy should be fine, so the latest one that supports 3.6 is fine

EmilioPeJu commented 2 years ago

I don't think there is a combination of packages versions that works for 3.6, 3.7, 3.8 and 3.9, I think I'm gonna close this and wait for RHEL8 to update python.... In the meantime, I will be running on virtual environments

thomascobb commented 2 years ago

If you do the changes on https://gitlab.diamond.ac.uk/controls/templates/dls_python3_template_module/-/merge_requests/21/diffs and https://gitlab.diamond.ac.uk/controls/templates/dls_python3_template_module/-/merge_requests/22/diffs then you don't have to have a consistent lockfile between pythons, just on 3.7

EmilioPeJu commented 2 years ago

I'm not sure it is worth it, I have two blockers:

asyncio seems to have changed too much between 3.6 and 3.7
Building docs fails because of warnings (which might be related with the removed import line)

thomascobb commented 2 years ago

https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task says Prior to Python 3.7, the low-level asyncio.ensure_future() function can be used instead
I'm sure we can fix the docs, probably just needs an intersphinx link

thomascobb commented 2 years ago

If you fix the first, I'll merge then fix the second in another PR

EmilioPeJu commented 2 years ago

Done! tests are now happy Thanks for the information on ensure_future()

EmilioPeJu commented 2 years ago

I'll rename the commit