search

dls-controls / dev-c7

A container for running the DLS Controls RHEL7 developer environment on a RHEL8 workstation
Apache License 2.0
0 stars 2 forks source link

Download link broken in documentation #59

Open joeshannon opened 2 years ago

joeshannon commented 2 years ago

The link to download the script here is broken. The link in question is https://github.com/dls-controls/dev-c7/releases/download/main/run-dev-c7.sh

Looking at the docs source it is parameterised by the version. This will work for tags which have a corresponding GitHub release but for the main docs build it fails as there is no "main" release.

It could be switched to use "latest" i.e. https://github.com/dls-controls/dev-c7/releases/latest/download/run-dev-c7.sh or to download the raw file on main which would be https://raw.githubusercontent.com/dls-controls/dev-c7/main/run-dev-c7.sh.

gilesknap commented 2 years ago

Sorry I seem to have missed this issue for 5 weeks!

What happens is the CI patches the file with the current version and adds it as a release asset. The comments in the docs above are supposed to make you use the correct version of the docs

IMPORTANT: before doing the next steps go to ‘Other Versions’ at the bottom of the left side-bar and select the version you want. The latest version is recommended

This is a bit crap really and is all to do with trying to tie the launch script and the version of the container together.

Maybe we should just go with latest as you say. Its possible to request a different version of the container from the run script args but the problem with latest is you have no sight of what you are currently running.