search

dls-controls / dev-c7

A container for running the DLS Controls RHEL7 developer environment on a RHEL8 workstation
Apache License 2.0
0 stars 2 forks source link

Update git install to enable https protocol #84

Closed GDYendell closed 1 year ago

GDYendell commented 1 year ago

This allows pip installing from https URLs

gilesknap commented 1 year ago

@GDYendell does this work for you? I made a hacky update to the c7 script that worked around the http issue. Maybe that was not needed.

See https://github.com/dls-controls/dev-c7/commit/1dbbc47eaba138b735266fe2d071fa5bdedfb52d

GDYendell commented 1 year ago

I think so...

I was 10 commits behind master when I did this. It allowed me to pip install a package that had a requirement with a https URL where before this change I would get:

❯ git clone -q https://github.com/dls-controls/sphinx-multiversion.git
git: 'remote-https' is not a git command. See 'git --help'.

Is that the same issue?

I just did a sudo yum install libcurl-devel and sudo yum install git inside the container and then it worked.

I have tried applying this commit earlier in history here and it works (with the c7 script version in that branch).

The fix was based on https://stackoverflow.com/questions/51366101/git-remote-https-is-not-a-git-command.

gilesknap commented 1 year ago

@GDYendell when I looked at this it seemed that the yum package was corrupted and installing it at runtime fixed the issue so there was some difference between build time and runtime.

So we need to try your fix on a fresh container and if it works we should remove the commit I linked above (I think you are saying that you have already tested it on a fresh container right ?)