Closed Araneidae closed 2 years ago
Merging #82 (3a5586e) into master (0ace830) will increase coverage by
0.23%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 87.36% 87.59% +0.23%
==========================================
Files 13 13
Lines 910 927 +17
==========================================
+ Hits 795 812 +17
Misses 115 115
Impacted Files | Coverage Δ | |
---|---|---|
softioc/builder.py | 97.40% <100.00%> (+0.32%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0ace830...3a5586e. Read the comment docs.
12 files ± 0 12 suites ±0 15m 24s :stopwatch: +27s 224 tests + 4 218 :heavy_check_mark: + 4 6 :zzz: ±0 0 :x: ±0 2 688 runs +48 2 340 :heavy_check_mark: +48 348 :zzz: ±0 0 :x: ±0
Results for commit 3a5586eb. ± Comparison against base commit 0ace8305.
:recycle: This comment has been updated with latest results.
Regarding the lack of tests, I agree that it would be good to add some more tests.
This commit addresses both github issues #81 and #67.
The arguments to the a and long record builder functions (
aIn
,aOut
,longIn
,longOut
) are brought more into line with the arguments as used in the epics_device module. This means that extra unnamed arguments can be used to specify EGU and PREC (where appropriate), and for out records the DRV limits take precedence.As a side effect, the implementation of this is made closer to that in https://github.com/dls-controls/epics_device/