dls-controls / pythonSoftIOC

Embed an EPICS IOC in a Python process
Apache License 2.0
32 stars 7 forks source link

Package sdist properly #86

Closed thomascobb closed 2 years ago

thomascobb commented 2 years ago

Fixes #83

codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (10192bb) into master (b0d2ef7) will decrease coverage by 0.10%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   87.70%   87.59%   -0.11%     
==========================================
  Files          13       13              
  Lines         927      927              
==========================================
- Hits          813      812       -1     
- Misses        114      115       +1     
Impacted Files Coverage Δ
softioc/__main__.py 0.00% <0.00%> (-5.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0d2ef7...10192bb. Read the comment docs.

github-actions[bot] commented 2 years ago

Unit Test Results

     15 files  ±0       15 suites  ±0   20m 42s :stopwatch: + 1m 53s    224 tests ±0     218 :heavy_check_mark: ±0      6 :zzz: ±0  0 :x: ±0  3 360 runs  ±0  2 925 :heavy_check_mark: ±0  435 :zzz: ±0  0 :x: ±0 

Results for commit 10192bbf. ± Comparison against base commit b0d2ef7d.

:recycle: This comment has been updated with latest results.

AlexanderWells-diamond commented 2 years ago

Are you thinking of keeping the -X faulthandler with pytest's -s flag? Does it give readable results in case of a failure?

thomascobb commented 2 years ago

Are you thinking of keeping the -X faulthandler with pytest's -s flag? Does it give readable results in case of a failure?

Yes, it is enabled just for windows, which doesn't add any extra output. It hasn't failed yet, so no idea if it gives more readable results, we'll have to wait and see!