search

dlsc-software-consulting-gmbh / GemsFX

A collection of JavaFX controls and utilities.
Apache License 2.0
445 stars 52 forks source link

Highlights misalignment fix #7

Closed PrimosK closed 4 years ago

PrimosK commented 4 years ago

Fixes issue #6

The current solution was build on the assumption that textPositions array will always be of the same length as snippet text but that's not the case. This fix takes the different length of these two into account.

Side note: I've tested this fix on the PDF provided in the #6.

dlemmermann commented 4 years ago

Nice catch.

PrimosK commented 4 years ago

Dirk, as commit was merged I wonder whether it's OK to close the related issue (#6)? Or will you take care of that? What is usual workflow?

dlemmermann commented 4 years ago

I will do that, but still need to test.

On 8 Apr 2020, at 09:39, PrimosK notifications@github.com wrote:

Dirk, as commit was merged I wonder whether it's OK to close the related issue (#6 https://github.com/dlsc-software-consulting-gmbh/GemsFX/issues/6)? Or will you take care of that? What is usual workflow?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dlsc-software-consulting-gmbh/GemsFX/pull/7#issuecomment-610802699, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIXWXKLGUVBC3GEWHFFKPDRLQSZ5ANCNFSM4MDAAXUA.