search

dlsc-software-consulting-gmbh / PDFViewFX

A PDF view for JavaFX applications.
Apache License 2.0
73 stars 14 forks source link

Internal depdency conflict #20

Open effad opened 3 weeks ago

effad commented 3 weeks ago

When trying to integrate PDFViewFX into our application (which has very strict checking of dependencies) we get the following conflict:

> Task :checkDuplicates
org.openjfx:javafx-controls:19
  Variant runtime:
    | Attribute Name             | Provided     | Requested |
    |----------------------------|--------------|-----------|
    | org.gradle.category        | library      |           |
    | org.gradle.libraryelements | jar          |           |
    | org.gradle.status          | release      |           |
    | org.gradle.usage           | java-runtime |           |
   Selection reasons:
      - By conflict resolution: between versions 19 and 18

org.openjfx:javafx-controls:19
\--- com.dlsc.pdfviewfx:pdfviewfx:3.1.0
     \--- dependencyCheck

org.openjfx:javafx-controls:18 -> 19
+--- com.dlsc.unitfx:unitfx:1.0.10
|    \--- dependencyCheck
\--- org.openjfx:javafx-fxml:18
     \--- com.dlsc.unitfx:unitfx:1.0.10 (*)

So while pdfviewfx wants javafx-controls:19, the com.dlsc.unitfx:unitfx Library wants javafx-controls:18.

We can exclude the dependencies manually but it would be better if PDFViewFX had consistent dependencies (or no dependencies at all if (as I suspect) any (modern) JavaFX-Version can be used.

dlemmermann commented 3 weeks ago

You can control the "required JavaFX version" by setting this property: 19</javafx.version>.