search

dlsc-software-consulting-gmbh / PreferencesFX

A framework for easily creating a UI for application settings / preferences.
Apache License 2.0
584 stars 67 forks source link

Missing legend with quicklinks in the ReadMe. #48

Closed Naoghuman closed 5 years ago

Naoghuman commented 5 years ago

Missing legend with quicklinks in the ReadMe.

In your amazing ReadMe I missing after the start section the legend with the quicklinks in the ReadMe which allowed the interested to jump quickly the section from interest.

Have a look in the ReadMe from https://github.com/openjfx/samples after the section 'Description'. When you want I can create a PR.

martinfrancois commented 5 years ago

Hi @Naoghuman

Thanks for the suggestion! In fact, over at https://github.com/dlemmermann/WorkbenchFX we do have a table of contents. Feel free to implement it and submit a PR.

Thanks! François

Naoghuman commented 5 years ago

https://github.com/dlemmermann/WorkbenchFX is an own repository and by the way I don't see a mention in the ReadMe from WorkbenchFX to this project (only 'All the specified button types will be set (eg. OK, CANCEL and APPLY for a preferences dialog)' but I think thats not relevant?).

I will prepare a PR.

martinfrancois commented 5 years ago

Merged PR #49.