search

dlsyscourse / hw1

7 stars 27 forks source link

Hw1 question 2 issue #2

Closed CalebDu closed 2 years ago

CalebDu commented 2 years ago

I have a problem about test code of HW1 question2. In gradient_check() function, out.backward() needs to call compute_gradient_of_variables() function which is implemented in question4. How to verify code in question2 without implementation of compute_gradient_of_variables() ? I am confused.

ashertrockman commented 2 years ago

Thanks for pointing this out -- just fixed it.

See https://github.com/dlsyscourse/hw1/commit/8622b2c92cc571364149b702ffa0ed647a34be6d